Re: [Mesa-dev] [PATCH 3/7] mesa: correctly manage GroupStackDepth

2015-11-22 Thread Timothy Arceri
On Mon, 2015-11-23 at 00:20 +, Emil Velikov wrote: > On 22 November 2015 at 23:53, Ilia Mirkin wrote: > > On Sun, Nov 22, 2015 at 6:50 PM, Emil Velikov > > wrote: > > > On 22 November 2015 at 23:22, Ilia Mirkin wrote: > > > > There are some places that you're not fixing up... > > > I thought

Re: [Mesa-dev] [PATCH 3/7] mesa: correctly manage GroupStackDepth

2015-11-22 Thread Emil Velikov
On 22 November 2015 at 23:53, Ilia Mirkin wrote: > On Sun, Nov 22, 2015 at 6:50 PM, Emil Velikov > wrote: >> On 22 November 2015 at 23:22, Ilia Mirkin wrote: >>> There are some places that you're not fixing up... >> I thought I fixed all cases - which ones do you have in mind ? The >> ones in d

Re: [Mesa-dev] [PATCH 3/7] mesa: correctly manage GroupStackDepth

2015-11-22 Thread Ilia Mirkin
On Sun, Nov 22, 2015 at 6:50 PM, Emil Velikov wrote: > On 22 November 2015 at 23:22, Ilia Mirkin wrote: >> There are some places that you're not fixing up... > I thought I fixed all cases - which ones do you have in mind ? The > ones in debug_destroy() or the comparison in _mesa_PushDebugGroup()

Re: [Mesa-dev] [PATCH 3/7] mesa: correctly manage GroupStackDepth

2015-11-22 Thread Emil Velikov
On 22 November 2015 at 23:22, Ilia Mirkin wrote: > There are some places that you're not fixing up... I thought I fixed all cases - which ones do you have in mind ? The ones in debug_destroy() or the comparison in _mesa_PushDebugGroup() ? > would this > alternatively be resolved by returning Grou

Re: [Mesa-dev] [PATCH 3/7] mesa: correctly manage GroupStackDepth

2015-11-22 Thread Ilia Mirkin
There are some places that you're not fixing up... would this alternatively be resolved by returning GroupStackDepth+1 in _mesa_get_debug_state_int and leaving everything else alone? On Sun, Nov 22, 2015 at 6:21 PM, Emil Velikov wrote: > The variable represents the length/size of the stack, thus

[Mesa-dev] [PATCH 3/7] mesa: correctly manage GroupStackDepth

2015-11-22 Thread Emil Velikov
The variable represents the length/size of the stack, thus (based on the spec requirement and the allocation above) it should be set to 1. This means that we have to use GroupStackDepth-1 to access the correct entry in the array. Signed-off-by: Emil Velikov --- src/mesa/main/errors.c | 17 +