Re: [Mesa-dev] [PATCH 3/7] EGL: Implement remaining functions from EGL_KHR_debug

2016-09-09 Thread Emil Velikov
On 8 September 2016 at 19:10, Adam Jackson wrote: > On Thu, 2016-09-08 at 11:57 -0600, Kyle Brenneman wrote: >> This one has the a bug in it where it doesn't set the callback if >> (attrib_list == NULL), plus the more minor bug where it doesn't check >> for invalid attributes if (callback == NULL)

Re: [Mesa-dev] [PATCH 3/7] EGL: Implement remaining functions from EGL_KHR_debug

2016-09-08 Thread Adam Jackson
On Thu, 2016-09-08 at 11:57 -0600, Kyle Brenneman wrote: > This one has the a bug in it where it doesn't set the callback if  > (attrib_list == NULL), plus the more minor bug where it doesn't check  > for invalid attributes if (callback == NULL). The first one is the same  > bug you noticed in libg

Re: [Mesa-dev] [PATCH 3/7] EGL: Implement remaining functions from EGL_KHR_debug

2016-09-08 Thread Kyle Brenneman
This one has the a bug in it where it doesn't set the callback if (attrib_list == NULL), plus the more minor bug where it doesn't check for invalid attributes if (callback == NULL). The first one is the same bug you noticed in libglvnd, which got copied over when I adapted it for Mesa. I can fi

[Mesa-dev] [PATCH 3/7] EGL: Implement remaining functions from EGL_KHR_debug

2016-09-08 Thread Adam Jackson
From: Kyle Brenneman Implemented eglDebugMessageControlKHR and eglQueryDebugKHR. Added entries in _egl_global to hold the debug callback and the set of enabled message types. Added a _eglDebugReport function to report a debug message, plus some macros for each of the message types. Still to do