Re: [Mesa-dev] [PATCH 3/5] panfrost: Mark BOs as NOEXEC

2019-08-06 Thread Tomeu Vizoso
On Mon, 5 Aug 2019 at 19:06, Alyssa Rosenzweig wrote: > > > +if (screen->kernel_version >= 1) { > > Maybe have some #defines for kernel versions instead of magic numbers? > Also, maybe make it clear that this is a minor version -- what does > happen if we bump the major version at some poi

Re: [Mesa-dev] [PATCH 3/5] panfrost: Mark BOs as NOEXEC

2019-08-05 Thread Alyssa Rosenzweig
> +if (screen->kernel_version >= 1) { Maybe have some #defines for kernel versions instead of magic numbers? Also, maybe make it clear that this is a minor version -- what does happen if we bump the major version at some point...? > panfrost_create_screen(int fd, struct renderonly *ro) >

[Mesa-dev] [PATCH 3/5] panfrost: Mark BOs as NOEXEC

2019-08-05 Thread Tomeu Vizoso
Unless a BO has the EXECUTABLE flag, mark it as NOEXEC. Signed-off-by: Tomeu Vizoso --- include/drm-uapi/panfrost_drm.h | 27 +++ src/gallium/drivers/panfrost/pan_drm.c| 7 +- src/gallium/drivers/panfrost/pan_screen.c | 12 ++ src/gallium/drivers/pa