Re: [Mesa-dev] [PATCH 3/5] nir: Fix setup of constant bool initializers.

2015-01-22 Thread Connor Abbott
On Wed, Jan 21, 2015 at 11:03 PM, Jason Ekstrand wrote: > Connor wrote *exactly* the same patch: > > http://lists.freedesktop.org/archives/mesa-dev/2015-January/074522.html > > This version can have my R-B too. And, fwiw, I like your commit message > better. Indeed... let's push this version, si

Re: [Mesa-dev] [PATCH 3/5] nir: Fix setup of constant bool initializers.

2015-01-21 Thread Jason Ekstrand
Connor wrote *exactly* the same patch: http://lists.freedesktop.org/archives/mesa-dev/2015-January/074522.html This version can have my R-B too. And, fwiw, I like your commit message better. On Wed, Jan 21, 2015 at 5:25 PM, Eric Anholt wrote: > brw_fs_nir has only seen scalar bools so far, th

[Mesa-dev] [PATCH 3/5] nir: Fix setup of constant bool initializers.

2015-01-21 Thread Eric Anholt
brw_fs_nir has only seen scalar bools so far, thanks to vector splitting, and the ralloc of in glsl_to_nir.cpp will *usually* get you a 0-filled chunk of memory, so reading too large of a value will usually get you the right bool value. But once we start doing vector bools in a few commits, we end