Re: [Mesa-dev] [PATCH 3/5] nir: Avoid structure initalization expressions.

2016-04-14 Thread Emil Velikov
On 13 April 2016 at 20:16, Jason Ekstrand wrote: > I guess I'm ok with the inline. I think it's ugly and nasty but the > compiler should get rid of it just fine. So I've converted this as an Acked-by, squashed the typo (Ian) and pushed the series. Thanks Emil P.S. And yes it does look a bit ug

Re: [Mesa-dev] [PATCH 3/5] nir: Avoid structure initalization expressions.

2016-04-13 Thread Jason Ekstrand
On Wed, Apr 13, 2016 at 11:53 AM, Jose Fonseca wrote: > On 13/04/16 19:35, Jason Ekstrand wrote: > >> >> >> On Wed, Apr 13, 2016 at 10:19 AM, Emil Velikov > > wrote: >> >> From: Jose Fonseca mailto:jfons...@vmware.com>> >> >> Not supported by MSVC, and com

Re: [Mesa-dev] [PATCH 3/5] nir: Avoid structure initalization expressions.

2016-04-13 Thread Jose Fonseca
On 13/04/16 19:35, Jason Ekstrand wrote: On Wed, Apr 13, 2016 at 10:19 AM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: From: Jose Fonseca mailto:jfons...@vmware.com>> Not supported by MSVC, and completely unnecessary -- inline functions work just as well. NIR_SRC_IN

Re: [Mesa-dev] [PATCH 3/5] nir: Avoid structure initalization expressions.

2016-04-13 Thread Jason Ekstrand
On Wed, Apr 13, 2016 at 10:19 AM, Emil Velikov wrote: > From: Jose Fonseca > > Not supported by MSVC, and completely unnecessary -- inline functions > work just as well. > > NIR_SRC_INIT/NIR_DEST_INIT could and probably should be replaced by the > inline functions. > > Cc: Jason Ekstrand > > --

[Mesa-dev] [PATCH 3/5] nir: Avoid structure initalization expressions.

2016-04-13 Thread Emil Velikov
From: Jose Fonseca Not supported by MSVC, and completely unnecessary -- inline functions work just as well. NIR_SRC_INIT/NIR_DEST_INIT could and probably should be replaced by the inline functions. Cc: Jason Ekstrand --- Jason, I believe you (used to) have an alternative in the vulkan branch