Re: [Mesa-dev] [PATCH 3/5] mesa: Handle clip control in meta operations.

2014-10-30 Thread Brian Paul
On 10/30/2014 09:08 AM, Neil Roberts wrote: Brian Paul writes: We've always put GL state into the attribute group specified by the GL specification. Putting the new clip control state anywhere but in the gl_context::Transform group would be inconsistent. I think Mathias was asking whether i

Re: [Mesa-dev] [PATCH 3/5] mesa: Handle clip control in meta operations.

2014-10-30 Thread Neil Roberts
Brian Paul writes: > We've always put GL state into the attribute group specified by the GL > specification. Putting the new clip control state anywhere but in the > gl_context::Transform group would be inconsistent. I think Mathias was asking whether it could be put under a different *meta*

Re: [Mesa-dev] [PATCH 3/5] mesa: Handle clip control in meta operations.

2014-10-30 Thread Brian Paul
On 10/29/2014 11:13 PM, Mathias Fröhlich wrote: Hi Neil, On Tuesday, October 28, 2014 18:22:33 Neil Roberts wrote: On inspection it looks like this would potentially break _mesa_meta_Clear when it is using GLSL because that does not save the MESA_META_TRANSFORM state. I wonder if MESA_META_TR

Re: [Mesa-dev] [PATCH 3/5] mesa: Handle clip control in meta operations.

2014-10-30 Thread Neil Roberts
Hi, Mathias Fröhlich writes: > That moved to MESA_META_TRANSFORM due to a review request. As I > understood the rationale, it's already connected to the > gl_context::Transform variable by the GL spec, so it belongs into > transform also for meta operations. Brian, or what was there an other > r

Re: [Mesa-dev] [PATCH 3/5] mesa: Handle clip control in meta operations.

2014-10-29 Thread Mathias Fröhlich
Hi Neil, On Tuesday, October 28, 2014 18:22:33 Neil Roberts wrote: > On inspection it looks like this would potentially break > _mesa_meta_Clear when it is using GLSL because that does not save the > MESA_META_TRANSFORM state. > > I wonder if MESA_META_TRANSFORM is not the right state flag for t

Re: [Mesa-dev] [PATCH 3/5] mesa: Handle clip control in meta operations.

2014-10-28 Thread Neil Roberts
On inspection it looks like this would potentially break _mesa_meta_Clear when it is using GLSL because that does not save the MESA_META_TRANSFORM state. I wonder if MESA_META_TRANSFORM is not the right state flag for this because all of the other state in it is about fixed-function stuff which is

Re: [Mesa-dev] [PATCH 3/5] mesa: Handle clip control in meta operations.

2014-10-24 Thread Jason Ekstrand
This patch breaks a lot of piglit on my HSW. https://bugs.freedesktop.org/show_bug.cgi?id=85425 On Fri, Oct 24, 2014 at 12:26 AM, wrote: > From: Mathias Fröhlich > > Restore clip control to the default state if MESA_META_VIEWPORT > or MESA_META_DEPTH_TEST is requested. > > v3: > Handle clip co

[Mesa-dev] [PATCH 3/5] mesa: Handle clip control in meta operations.

2014-10-24 Thread Mathias . Froehlich
From: Mathias Fröhlich Restore clip control to the default state if MESA_META_VIEWPORT or MESA_META_DEPTH_TEST is requested. v3: Handle clip control state with MESA_META_TRANSFORM. Signed-off-by: Mathias Froehlich --- src/mesa/drivers/common/meta.c | 6 ++ src/mesa/drivers/common/meta.h |

Re: [Mesa-dev] [PATCH 3/5] mesa: Handle clip control in meta operations.

2014-10-22 Thread Brian Paul
On 10/22/2014 11:13 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Restore clip control to the default state if MESA_META_VIEWPORT or MESA_META_DEPTH_TEST is requested. Signed-off-by: Mathias Froehlich --- src/mesa/drivers/common/meta.c | 13 + src/mesa/drivers/com

[Mesa-dev] [PATCH 3/5] mesa: Handle clip control in meta operations.

2014-10-22 Thread Mathias . Froehlich
From: Mathias Fröhlich Restore clip control to the default state if MESA_META_VIEWPORT or MESA_META_DEPTH_TEST is requested. Signed-off-by: Mathias Froehlich --- src/mesa/drivers/common/meta.c | 13 + src/mesa/drivers/common/meta.h | 4 2 files changed, 17 insertions(+) diff