Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

2018-11-01 Thread Tapani Pälli
On 11/1/18 11:59 AM, Erik Faye-Lund wrote: On Thu, 2018-11-01 at 07:49 +0200, Tapani Pälli wrote: On 10/31/18 7:03 PM, Ilia Mirkin wrote: On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund wrote: On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: I had to do a double (or triple) take on

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

2018-11-01 Thread Erik Faye-Lund
On Thu, 2018-11-01 at 07:49 +0200, Tapani Pälli wrote: > > On 10/31/18 7:03 PM, Ilia Mirkin wrote: > > On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund > > wrote: > > > > > > On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: > > > > I had to do a double (or triple) take on this logic as well.

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

2018-10-31 Thread Tapani Pälli
On 10/31/18 7:03 PM, Ilia Mirkin wrote: On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund wrote: On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: I had to do a double (or triple) take on this logic as well. Part of the subtlety is that the fallback only applies for ES when there's a matc

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

2018-10-31 Thread Ilia Mirkin
On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund wrote: > > On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: > > I had to do a double (or triple) take on this logic as well. Part of > > the subtlety is that the fallback only applies for ES when there's a > > match but no exact match. Probably

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

2018-10-31 Thread Erik Faye-Lund
On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: > I had to do a double (or triple) take on this logic as well. Part of > the subtlety is that the fallback only applies for ES when there's a > match but no exact match. Probably good to mention this. Yeah, that makes sense. I thought I mention

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

2018-10-31 Thread Ilia Mirkin
I had to do a double (or triple) take on this logic as well. Part of the subtlety is that the fallback only applies for ES when there's a match but no exact match. Probably good to mention this. On Wed, Oct 31, 2018 at 11:13 AM Erik Faye-Lund wrote: > > On Wed, 2018-10-31 at 15:46 +0200, Tapani Pä

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

2018-10-31 Thread Erik Faye-Lund
On Wed, 2018-10-31 at 15:46 +0200, Tapani Pälli wrote: > > On 10/30/18 7:11 PM, Erik Faye-Lund wrote: > > In GLES, we currently either need an exact match with a local > > function, > > or an exact match with a builtin. > > > > However, if we add support for implicit conversions for GLES > > shad

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

2018-10-31 Thread Tapani Pälli
On 10/30/18 7:11 PM, Erik Faye-Lund wrote: In GLES, we currently either need an exact match with a local function, or an exact match with a builtin. However, if we add support for implicit conversions for GLES shaders, we also need to fall back to a non-exact match in the case where there were

[Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

2018-10-30 Thread Erik Faye-Lund
In GLES, we currently either need an exact match with a local function, or an exact match with a builtin. However, if we add support for implicit conversions for GLES shaders, we also need to fall back to a non-exact match in the case where there were no builtin match either. Luckily, we already