Re: [Mesa-dev] [PATCH 3/4] radeonsi: add support for an on-disk shader cache

2017-03-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Mar 1, 2017 at 6:25 AM, Timothy Arceri wrote: > V2: > - when loading from disk cache also binary insert into memory cache. > - check that the binary loaded from disk is the correct size. If not > delete the cache item and skip loading from cache. > > V3:

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add support for an on-disk shader cache

2017-03-01 Thread Timothy Arceri
On 02/03/17 10:33, Axel Davy wrote: On 02/03/2017 00:27, Timothy Arceri wrote: On 01/03/17 18:36, Axel Davy wrote: My understanding of the code is that the disk cache just depends on the sscreen->b.disk_shader_cache being initialized, and it looks like this is always initialized. Thus the d

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add support for an on-disk shader cache

2017-03-01 Thread Axel Davy
On 02/03/2017 00:27, Timothy Arceri wrote: On 01/03/17 18:36, Axel Davy wrote: My understanding of the code is that the disk cache just depends on the sscreen->b.disk_shader_cache being initialized, and it looks like this is always initialized. Thus the disk cache is always enabled. Could you

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add support for an on-disk shader cache

2017-03-01 Thread Timothy Arceri
On 01/03/17 18:36, Axel Davy wrote: My understanding of the code is that the disk cache just depends on the sscreen->b.disk_shader_cache being initialized, and it looks like this is always initialized. Thus the disk cache is always enabled. Could you add a RADEON_DEBUG env var to disable it, p

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add support for an on-disk shader cache

2017-02-28 Thread Axel Davy
My understanding of the code is that the disk cache just depends on the sscreen->b.disk_shader_cache being initialized, and it looks like this is always initialized. Thus the disk cache is always enabled. Could you add a RADEON_DEBUG env var to disable it, please ? Thanks, Axel Davy On 01/03

[Mesa-dev] [PATCH 3/4] radeonsi: add support for an on-disk shader cache

2017-02-28 Thread Timothy Arceri
V2: - when loading from disk cache also binary insert into memory cache. - check that the binary loaded from disk is the correct size. If not delete the cache item and skip loading from cache. V3: - remove unrequired variable Tested-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_state_