Re: [Mesa-dev] [PATCH 3/4] panfrost: Implement perfcnt hooks in the DRM driver

2019-04-04 Thread Boris Brezillon
On Thu, 4 Apr 2019 08:52:26 -0700 Alyssa Rosenzweig wrote: > > + struct pandrost_drm_perfcnt_query *data; > > Typo. How did that even compile? --Oh, wait, you have that typo > throughout the file. > > s/pandrost/panfrost/g, please ;) Will fix that :-) > > --- > > Other than that, Review

Re: [Mesa-dev] [PATCH 3/4] panfrost: Implement perfcnt hooks in the DRM driver

2019-04-04 Thread Alyssa Rosenzweig
> + struct pandrost_drm_perfcnt_query *data; Typo. How did that even compile? --Oh, wait, you have that typo throughout the file. s/pandrost/panfrost/g, please ;) --- Other than that, Reviewed-by: Alyssa Rosenzweig ___ mesa-dev mailing list mesa-

[Mesa-dev] [PATCH 3/4] panfrost: Implement perfcnt hooks in the DRM driver

2019-04-04 Thread Boris Brezillon
Use the PERFMON/PERFCNT ioctls to get HW counters. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_drm.c | 245 + 1 file changed, 245 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c index 4b8