Re: [Mesa-dev] [PATCH 3/4] i965: Add code to verify the CFG is sane.

2014-11-06 Thread Matt Turner
On Thu, Nov 6, 2014 at 9:41 AM, Jason Ekstrand wrote: > In general, it seems as if this can miss several things. For instance, it > checks that all the predicessors are valid but never that we have all the > predecessors. I'm not sure what you mean. That we don't validate that if A -> B then B h

Re: [Mesa-dev] [PATCH 3/4] i965: Add code to verify the CFG is sane.

2014-11-06 Thread Jason Ekstrand
In general, it seems as if this can miss several things. For instance, it checks that all the predicessors are valid but never that we have all the predecessors. Same for successors. If we really want to be able to validate a CFG, maybe a stack-based approach like calculate_cfg would work better

[Mesa-dev] [PATCH 3/4] i965: Add code to verify the CFG is sane.

2014-11-05 Thread Matt Turner
--- src/mesa/drivers/dri/i965/test_verify_cfg.cpp | 273 ++ src/mesa/drivers/dri/i965/test_verify_cfg.h | 26 +++ 2 files changed, 299 insertions(+) create mode 100644 src/mesa/drivers/dri/i965/test_verify_cfg.cpp create mode 100644 src/mesa/drivers/dri/i965/test_verif