Re: [Mesa-dev] [PATCH 3/4] i965/vs: Add simple dead code elimination.

2011-08-19 Thread Kenneth Graunke
On 08/19/2011 10:58 AM, Dan McCabe wrote: > On 08/18/2011 01:23 PM, Kenneth Graunke wrote: >> On 08/18/2011 12:02 PM, Matt Turner wrote: >>> On Thu, Aug 18, 2011 at 2:38 PM, Eric Anholt wrote: + bool progress = true; + while (progress) { + progress = false; + prog

Re: [Mesa-dev] [PATCH 3/4] i965/vs: Add simple dead code elimination.

2011-08-19 Thread Dan McCabe
On 08/18/2011 01:23 PM, Kenneth Graunke wrote: On 08/18/2011 12:02 PM, Matt Turner wrote: On Thu, Aug 18, 2011 at 2:38 PM, Eric Anholt wrote: + bool progress = true; + while (progress) { + progress = false; + progress = dead_code_eliminate() || progress; || progress is always f

Re: [Mesa-dev] [PATCH 3/4] i965/vs: Add simple dead code elimination.

2011-08-18 Thread Kenneth Graunke
On 08/18/2011 12:02 PM, Matt Turner wrote: > On Thu, Aug 18, 2011 at 2:38 PM, Eric Anholt wrote: >> + bool progress = true; >> + while (progress) { >> + progress = false; >> + progress = dead_code_eliminate() || progress; > > || progress is always false, though maybe it's just writt

Re: [Mesa-dev] [PATCH 3/4] i965/vs: Add simple dead code elimination.

2011-08-18 Thread Matt Turner
On Thu, Aug 18, 2011 at 2:38 PM, Eric Anholt wrote: > +   bool progress = true; > +   while (progress) { > +      progress = false; > +      progress = dead_code_eliminate() || progress; || progress is always false, though maybe it's just written like that to match the style of the code. I'd hav

[Mesa-dev] [PATCH 3/4] i965/vs: Add simple dead code elimination.

2011-08-18 Thread Eric Anholt
This is copied right from the fragment shader. It is needed for real register allocation to work correctly. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 31 +++ src/mesa/drivers/dri/i965/brw_vec4.h|1 + src/mesa/drivers/dri/i965/brw_vec4_emit.cpp |6