Re: [Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

2018-01-02 Thread Grazvydas Ignotas
On Wed, Jan 3, 2018 at 3:09 AM, Ian Romanick wrote: > On 01/02/2018 04:52 PM, Grazvydas Ignotas wrote: >> On Tue, Jan 2, 2018 at 11:38 PM, Ian Romanick wrote: >>> On 12/28/2017 05:56 PM, Grazvydas Ignotas wrote: zlib provides a faster slice-by-4 CRC32 implementation than the traditional

Re: [Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

2018-01-02 Thread Ian Romanick
On 01/02/2018 04:52 PM, Grazvydas Ignotas wrote: > On Tue, Jan 2, 2018 at 11:38 PM, Ian Romanick wrote: >> On 12/28/2017 05:56 PM, Grazvydas Ignotas wrote: >>> zlib provides a faster slice-by-4 CRC32 implementation than the >>> traditional single byte lookup one used by mesa. As most supported >>>

Re: [Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

2018-01-02 Thread Grazvydas Ignotas
On Tue, Jan 2, 2018 at 11:38 PM, Ian Romanick wrote: > On 12/28/2017 05:56 PM, Grazvydas Ignotas wrote: >> zlib provides a faster slice-by-4 CRC32 implementation than the >> traditional single byte lookup one used by mesa. As most supported >> platforms now link zlib unconditionally, we can easily

Re: [Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

2018-01-02 Thread Ian Romanick
On 12/28/2017 05:56 PM, Grazvydas Ignotas wrote: > zlib provides a faster slice-by-4 CRC32 implementation than the > traditional single byte lookup one used by mesa. As most supported > platforms now link zlib unconditionally, we can easily use it. > For small buffers the old implementation is stil

[Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

2017-12-28 Thread Grazvydas Ignotas
zlib provides a faster slice-by-4 CRC32 implementation than the traditional single byte lookup one used by mesa. As most supported platforms now link zlib unconditionally, we can easily use it. For small buffers the old implementation is still used as it's faster with cold cache (first call), as in