Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

2017-06-28 Thread Emil Velikov
On 27 June 2017 at 16:02, Marek Olšák wrote: > On Tue, Jun 27, 2017 at 10:02 AM, Nicolai Hähnle wrote: >> On 27.06.2017 00:15, Marek Olšák wrote: >>> >>> On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle >>> wrote: On 20.06.2017 20:00, Marek Olšák wrote: > > > From: Marek Olš

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

2017-06-27 Thread Nicolai Hähnle
On 27.06.2017 17:02, Marek Olšák wrote: On Tue, Jun 27, 2017 at 10:02 AM, Nicolai Hähnle wrote: On 27.06.2017 00:15, Marek Olšák wrote: On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle wrote: On 20.06.2017 20:00, Marek Olšák wrote: From: Marek Olšák sizeof(struct si_shader_key): B

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

2017-06-27 Thread Marek Olšák
On Tue, Jun 27, 2017 at 10:02 AM, Nicolai Hähnle wrote: > On 27.06.2017 00:15, Marek Olšák wrote: >> >> On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle >> wrote: >>> >>> On 20.06.2017 20:00, Marek Olšák wrote: From: Marek Olšák sizeof(struct si_shader_key): Befo

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

2017-06-27 Thread Nicolai Hähnle
On 27.06.2017 00:15, Marek Olšák wrote: On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle wrote: On 20.06.2017 20:00, Marek Olšák wrote: From: Marek Olšák sizeof(struct si_shader_key): Before reverting the 2 commits: 120 bytes After reverting the 2 commits: 128 bytes With #pragma

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

2017-06-26 Thread Marek Olšák
On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle wrote: > On 20.06.2017 20:00, Marek Olšák wrote: >> >> From: Marek Olšák >> >> sizeof(struct si_shader_key): >>Before reverting the 2 commits: 120 bytes >>After reverting the 2 commits: 128 bytes >>With #pragma pack: 107 bytes >> >> I'm

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

2017-06-22 Thread Emil Velikov
Hi Marek, On 20 June 2017 at 19:00, Marek Olšák wrote: > From: Marek Olšák > > sizeof(struct si_shader_key): > Before reverting the 2 commits: 120 bytes > After reverting the 2 commits: 128 bytes > With #pragma pack: 107 bytes > > I'm not sure if memcmp with a byte-aligned size is a good i

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

2017-06-22 Thread Nicolai Hähnle
On 20.06.2017 20:00, Marek Olšák wrote: From: Marek Olšák sizeof(struct si_shader_key): Before reverting the 2 commits: 120 bytes After reverting the 2 commits: 128 bytes With #pragma pack: 107 bytes I'm not sure if memcmp with a byte-aligned size is a good idea. Does this have a me

[Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

2017-06-20 Thread Marek Olšák
From: Marek Olšák sizeof(struct si_shader_key): Before reverting the 2 commits: 120 bytes After reverting the 2 commits: 128 bytes With #pragma pack: 107 bytes I'm not sure if memcmp with a byte-aligned size is a good idea. --- src/gallium/drivers/radeonsi/si_shader.h | 8 1 file