Re: [Mesa-dev] [PATCH 3/3] r600g: handle unbind of constant buffers

2010-10-14 Thread Jerome Glisse
On Thu, Oct 14, 2010 at 12:00 PM, Keith Whitwell wrote: > Dave, > > Sorry for being confusing, but this patch doesn't actually work - this > is what I think should be happening, but at the moment I have to > return early to avoid segfaults on unbinding constant buffers, ie: > > +       if (buffer

Re: [Mesa-dev] [PATCH 3/3] r600g: handle unbind of constant buffers

2010-10-14 Thread Keith Whitwell
Dave, Sorry for being confusing, but this patch doesn't actually work - this is what I think should be happening, but at the moment I have to return early to avoid segfaults on unbinding constant buffers, ie: + if (buffer == NULL) { +return; +} +else {

[Mesa-dev] [PATCH 3/3] r600g: handle unbind of constant buffers

2010-10-14 Thread Keith Whitwell
Statetrackers can unbind a constant buffer slot by calling pipe->set_constant_buffer(pipe, shader, slot, NULL) The driver should unbind the buffer and potentially allow its storage to be released. --- src/gallium/drivers/r600/r600_state.c | 20 1 files changed, 16 inser