Re: [Mesa-dev] [PATCH 3/3] nir: simplify node matching code when lowering to SSA

2018-04-10 Thread Caio Marcelo de Oliveira Filho
On Tue, Apr 10, 2018 at 10:15:45PM -0700, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho < > caio.olive...@intel.com> wrote: > > > The matching code doesn't make real use of the return value. The main > > function return value is ignored, and while the wor

Re: [Mesa-dev] [PATCH 3/3] nir: simplify node matching code when lowering to SSA

2018-04-10 Thread Jason Ekstrand
On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > The matching code doesn't make real use of the return value. The main > function return value is ignored, and while the worker function > propagate its return value, the actual callback never retur

[Mesa-dev] [PATCH 3/3] nir: simplify node matching code when lowering to SSA

2018-04-10 Thread Caio Marcelo de Oliveira Filho
The matching code doesn't make real use of the return value. The main function return value is ignored, and while the worker function propagate its return value, the actual callback never returns false. --- src/compiler/nir/nir_lower_vars_to_ssa.c | 73 +++- 1 file changed, 32