Re: [Mesa-dev] [PATCH 3/3] nir: Rewrite lower_regs_to_ssa to use the phi builder

2016-12-16 Thread Jason Ekstrand
On Fri, Dec 16, 2016 at 11:08 AM, Jason Ekstrand wrote: > On Thu, Dec 15, 2016 at 6:29 PM, Jason Ekstrand > wrote: > >> On Dec 15, 2016 3:08 PM, "Eric Anholt" wrote: >> >> Jason Ekstrand writes: >> >> > This keeps some of Connor's original code. However, while I was at it, >> > I updated this

Re: [Mesa-dev] [PATCH 3/3] nir: Rewrite lower_regs_to_ssa to use the phi builder

2016-12-16 Thread Jason Ekstrand
On Thu, Dec 15, 2016 at 6:29 PM, Jason Ekstrand wrote: > On Dec 15, 2016 3:08 PM, "Eric Anholt" wrote: > > Jason Ekstrand writes: > > > This keeps some of Connor's original code. However, while I was at it, > > I updated this very old pass to a bit more modern NIR. > > I love how much smaller

Re: [Mesa-dev] [PATCH 3/3] nir: Rewrite lower_regs_to_ssa to use the phi builder

2016-12-15 Thread Jason Ekstrand
On Dec 15, 2016 3:08 PM, "Eric Anholt" wrote: Jason Ekstrand writes: > This keeps some of Connor's original code. However, while I was at it, > I updated this very old pass to a bit more modern NIR. I love how much smaller this code is. Assuming that the phi builder does that job correctly,

Re: [Mesa-dev] [PATCH 3/3] nir: Rewrite lower_regs_to_ssa to use the phi builder

2016-12-15 Thread Eric Anholt
Jason Ekstrand writes: > This keeps some of Connor's original code. However, while I was at it, > I updated this very old pass to a bit more modern NIR. I love how much smaller this code is. Assuming that the phi builder does that job correctly, this is pretty trivial to read and understand.

[Mesa-dev] [PATCH 3/3] nir: Rewrite lower_regs_to_ssa to use the phi builder

2016-12-14 Thread Jason Ekstrand
This keeps some of Connor's original code. However, while I was at it, I updated this very old pass to a bit more modern NIR. --- src/compiler/nir/nir_lower_regs_to_ssa.c | 583 +-- 1 file changed, 156 insertions(+), 427 deletions(-) diff --git a/src/compiler/nir/nir_