Re: [Mesa-dev] [PATCH 3/3] nir/validate: dump annotated shader with error msgs

2016-05-17 Thread Jason Ekstrand
I did a quick skim. LGTM. Series is Acked-by: Jason Ekstrand On Mon, May 16, 2016 at 4:46 PM, Connor Abbott wrote: > On Mon, May 16, 2016 at 12:54 PM, Rob Clark wrote: > > From: Rob Clark > > > > Log all the errors, and at the end dump the shader w/ error annotations > > to make it easier

Re: [Mesa-dev] [PATCH 3/3] nir/validate: dump annotated shader with error msgs

2016-05-16 Thread Connor Abbott
On Mon, May 16, 2016 at 12:54 PM, Rob Clark wrote: > From: Rob Clark > > Log all the errors, and at the end dump the shader w/ error annotations > to make it easier to see where the problems are. > > Signed-off-by: Rob Clark > Reviewed-by: Eduardo Lima Mitev > --- > src/compiler/nir/nir_valida

[Mesa-dev] [PATCH 3/3] nir/validate: dump annotated shader with error msgs

2016-05-16 Thread Rob Clark
From: Rob Clark Log all the errors, and at the end dump the shader w/ error annotations to make it easier to see where the problems are. Signed-off-by: Rob Clark Reviewed-by: Eduardo Lima Mitev --- src/compiler/nir/nir_validate.c | 60 - 1 file changed,