Re: [Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

2016-08-11 Thread Chad Versace
On 08/11/2016 10:22 AM, Ilia Mirkin wrote: On Thu, Aug 11, 2016 at 1:11 PM, Chad Versace wrote: If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when textarget is a valid GLenum but an invalid parameter to the current v

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

2016-08-11 Thread Ilia Mirkin
On Thu, Aug 11, 2016 at 1:11 PM, Chad Versace wrote: > If check_textarget() determined that textarget was incorrect, it emitted > GL_INVALID_OPERATION. This is the correct behavior when textarget is > a valid GLenum but an invalid parameter to the current variant of > glFramebufferTexture*(). > >

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

2016-08-11 Thread Ian Romanick
On 08/11/2016 10:11 AM, Chad Versace wrote: > If check_textarget() determined that textarget was incorrect, it emitted > GL_INVALID_OPERATION. This is the correct behavior when textarget is > a valid GLenum but an invalid parameter to the current variant of > glFramebufferTexture*(). > > However,

[Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

2016-08-11 Thread Chad Versace
If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when textarget is a valid GLenum but an invalid parameter to the current variant of glFramebufferTexture*(). However, when textarget is not a GLenum at all, then the GL spec