Re: [Mesa-dev] [PATCH 3/3] i965: Handle ir_binop_ubo_load in boolean expression code.

2014-09-04 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/3] i965: Handle ir_binop_ubo_load in boolean expression code.

2014-09-04 Thread Kenneth Graunke
UBO loads can be boolean-valued expressions, too, so we need to handle them in emit_bool_to_cond_code() and emit_if_gen6(). However, unlike most expressions, it doesn't make sense to evaluate their operands, then do something with the results. We just want to evaluate the UBO load as a whole---wh

[Mesa-dev] [PATCH 3/3] i965: Handle ir_binop_ubo_load in boolean expression code.

2014-09-04 Thread Kenneth Graunke
UBO loads can be boolean-valued expressions, too, so we need to handle them in emit_bool_to_cond_code() and emit_if_gen6(). However, unlike most expressions, it doesn't make sense to evaluate their operands, then do something with the results. We just want to evaluate the UBO load as a whole---wh