Re: [Mesa-dev] [PATCH 3/3] glsl: make loop unrolling more like the nir unrolling path

2017-09-21 Thread Timothy Arceri
On 18/09/17 21:43, Timothy Arceri wrote: On 18/09/17 20:50, Nicolai Hähnle wrote: On 14.09.2017 06:47, Timothy Arceri wrote: The old code incorrectly assumed that loop terminators will always be at the start of the loop. It really seems to be just luck that we haven't triggered any bugs here,

Re: [Mesa-dev] [PATCH 3/3] glsl: make loop unrolling more like the nir unrolling path

2017-09-18 Thread Timothy Arceri
On 18/09/17 20:50, Nicolai Hähnle wrote: On 14.09.2017 06:47, Timothy Arceri wrote: The old code incorrectly assumed that loop terminators will always be at the start of the loop. It really seems to be just luck that we haven't triggered any bugs here, for example if there is a loop terminator

Re: [Mesa-dev] [PATCH 3/3] glsl: make loop unrolling more like the nir unrolling path

2017-09-18 Thread Nicolai Hähnle
On 14.09.2017 06:47, Timothy Arceri wrote: The old code incorrectly assumed that loop terminators will always be at the start of the loop. It really seems to be just luck that we haven't triggered any bugs here, for example if there is a loop terminator at the start of the loop we might actually

[Mesa-dev] [PATCH 3/3] glsl: make loop unrolling more like the nir unrolling path

2017-09-13 Thread Timothy Arceri
The old code incorrectly assumed that loop terminators will always be at the start of the loop. It really seems to be just luck that we haven't triggered any bugs here, for example if there is a loop terminator at the start of the loop we might actually ignore any other terminators that might be la