Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-24 Thread Francisco Jerez
I'm attaching a somewhat cleaned up version of this patch, does it look OK to you? Tom, do you have any comments on the LLVM changes? It looks good to me. EdB writes: > --- > src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- > src/gallium/state_trackers/clover/api/program.cpp | 39

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-20 Thread EdB
Le 2014-10-20 09:42, Francisco Jerez a écrit : Francisco Jerez writes: EdB writes: Sorry, I didn't test it enought. It needs the two following patch in order to work ok EdB (2): clover: add allow_empty_tag clover: don't return CL_INVALID_VALUE if there is no header These look good,

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-20 Thread Francisco Jerez
Francisco Jerez writes: > EdB writes: > >> Sorry, I didn't test it enought. >> It needs the two following patch in order to work ok >> >> EdB (2): >> clover: add allow_empty_tag >> clover: don't return CL_INVALID_VALUE if there is no header >> > > These look good, > Reviewed-by: Francisco Je

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-11 Thread Francisco Jerez
EdB writes: > Sorry, I didn't test it enought. > It needs the two following patch in order to work ok > > EdB (2): > clover: add allow_empty_tag > clover: don't return CL_INVALID_VALUE if there is no header > These look good, Reviewed-by: Francisco Jerez > src/gallium/state_trackers/clove

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-11 Thread EdB
Sorry, I didn't test it enought. It needs the two following patch in order to work ok EdB (2): clover: add allow_empty_tag clover: don't return CL_INVALID_VALUE if there is no header src/gallium/state_trackers/clover/api/program.cpp | 2 +- src/gallium/state_trackers/clover/core/object.hpp

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-11 Thread EdB
On Friday 10 October 2014 15:45:51 Tom Stellard wrote: > On Fri, Oct 10, 2014 at 07:51:40PM +0200, EdB wrote: > > On Friday 10 October 2014 10:16:08 Tom Stellard wrote: > > > On Thu, Oct 09, 2014 at 09:22:46PM +0200, EdB wrote: > > > > On Thursday, October 09, 2014 06:29:40 AM Tom Stellard wrote: >

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-10 Thread Tom Stellard
On Fri, Oct 10, 2014 at 07:51:40PM +0200, EdB wrote: > On Friday 10 October 2014 10:16:08 Tom Stellard wrote: > > On Thu, Oct 09, 2014 at 09:22:46PM +0200, EdB wrote: > > > On Thursday, October 09, 2014 06:29:40 AM Tom Stellard wrote: > > > > On Sun, Sep 28, 2014 at 12:57:22PM +0200, EdB wrote: > >

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-10 Thread EdB
On Friday 10 October 2014 10:16:08 Tom Stellard wrote: > On Thu, Oct 09, 2014 at 09:22:46PM +0200, EdB wrote: > > On Thursday, October 09, 2014 06:29:40 AM Tom Stellard wrote: > > > On Sun, Sep 28, 2014 at 12:57:22PM +0200, EdB wrote: > > > > --- > > > > > > > > src/gallium/state_trackers/clover/

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-10 Thread Tom Stellard
On Thu, Oct 09, 2014 at 09:22:46PM +0200, EdB wrote: > On Thursday, October 09, 2014 06:29:40 AM Tom Stellard wrote: > > On Sun, Sep 28, 2014 at 12:57:22PM +0200, EdB wrote: > > > --- > > > > > > src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- > > > src/gallium/state_trackers/clover/a

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-09 Thread EdB
On Wednesday, October 08, 2014 08:31:39 PM Francisco Jerez wrote: > I'm attaching a somewhat cleaned up version of this patch, does it look > OK to you? Tom, do you have any comments on the LLVM changes? It looks > good to me. I've tested the modified version you push at http://cgit.freedesktop

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-09 Thread EdB
On Thursday, October 09, 2014 06:29:40 AM Tom Stellard wrote: > On Sun, Sep 28, 2014 at 12:57:22PM +0200, EdB wrote: > > --- > > > > src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- > > src/gallium/state_trackers/clover/api/program.cpp | 39 > > +++--- .../state_tracke

Re: [Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-10-09 Thread Tom Stellard
On Sun, Sep 28, 2014 at 12:57:22PM +0200, EdB wrote: > --- > src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- > src/gallium/state_trackers/clover/api/program.cpp | 39 > +++--- > .../state_trackers/clover/core/compiler.hpp| 12 --- > src/gallium/state_track

[Mesa-dev] [PATCH 3/3] clover: add clCompile

2014-09-28 Thread EdB
--- src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 39 +++--- .../state_trackers/clover/core/compiler.hpp| 12 --- src/gallium/state_trackers/clover/core/error.hpp | 2 +- src/gallium/state_trackers/cl