Re: [Mesa-dev] [PATCH 25/33] intel: compiler: abstract printing

2017-10-31 Thread Lionel Landwerlin
On 31/10/17 20:25, Scott D Phillips wrote: Lionel Landwerlin writes: This is required to have output redirected to something else than a file descriptor (stdout). an alternative here might be to fdopen() a pipe(). Maybe a bit weird but it could save several hundred lines of change and maybe g

Re: [Mesa-dev] [PATCH 25/33] intel: compiler: abstract printing

2017-10-31 Thread Scott D Phillips
Lionel Landwerlin writes: > This is required to have output redirected to something else than a > file descriptor (stdout). an alternative here might be to fdopen() a pipe(). Maybe a bit weird but it could save several hundred lines of change and maybe get you buffering to boot. however you feel

Re: [Mesa-dev] [PATCH 25/33] intel: compiler: abstract printing

2017-10-31 Thread Scott D Phillips
Lionel Landwerlin writes: > This is required to have output redirected to something else than a > file descriptor (stdout). > > Signed-off-by: Lionel Landwerlin > --- > src/intel/compiler/brw_compile_clip.c | 5 +- > src/intel/compiler/brw_compile_sf.c | 5 +- > src/intel/compiler

[Mesa-dev] [PATCH 25/33] intel: compiler: abstract printing

2017-10-30 Thread Lionel Landwerlin
This is required to have output redirected to something else than a file descriptor (stdout). Signed-off-by: Lionel Landwerlin --- src/intel/compiler/brw_compile_clip.c | 5 +- src/intel/compiler/brw_compile_sf.c | 5 +- src/intel/compiler/brw_disasm.c | 645 +