Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

2015-09-28 Thread Samuel Iglesias Gonsálvez
On 29/09/15 08:34, Timothy Arceri wrote: > On Thu, 2015-09-24 at 11:31 +0200, Samuel Iglesias Gonsálvez wrote: >> >> On 24/09/15 02:16, Timothy Arceri wrote: >>> On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote: On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: > Revi

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

2015-09-28 Thread Timothy Arceri
On Thu, 2015-09-24 at 11:31 +0200, Samuel Iglesias Gonsálvez wrote: > > On 24/09/15 02:16, Timothy Arceri wrote: > > On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote: > > > On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: > > > > Reviewed-by: Samuel Iglesias Gonsálvez > > > >

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

2015-09-24 Thread Samuel Iglesias Gonsálvez
On 24/09/15 02:16, Timothy Arceri wrote: > On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote: >> On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: >>> Reviewed-by: Samuel Iglesias Gonsálvez >>> >> >> Forgot to say that we need to implement a similar patch for >> std430_size()

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

2015-09-23 Thread Timothy Arceri
On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote: > On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: > > Reviewed-by: Samuel Iglesias Gonsálvez > > > > Forgot to say that we need to implement a similar patch for > std430_size() function, right? Yeah I think so. > > I will

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

2015-09-23 Thread Samuel Iglesias Gonsálvez
On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote: > Reviewed-by: Samuel Iglesias Gonsálvez > Forgot to say that we need to implement a similar patch for std430_size() function, right? I will write a follow-up patch adding std430 support for AoA. Sam > On 20/09/15 14:07, Timothy Arceri wrote:

Re: [Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

2015-09-22 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 20/09/15 14:07, Timothy Arceri wrote: > --- > I noticed this problem after adding AoA support [1] to Ian's random UBO test > script [2]. > > [1] http://patchwork.freedesktop.org/patch/59956/ > [2] http://cgit.freedesktop.org/~idr/piglit/log/?h=ubo-lo

[Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

2015-09-20 Thread Timothy Arceri
--- I noticed this problem after adding AoA support [1] to Ian's random UBO test script [2]. [1] http://patchwork.freedesktop.org/patch/59956/ [2] http://cgit.freedesktop.org/~idr/piglit/log/?h=ubo-lolz src/glsl/glsl_types.cpp | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(