Re: [Mesa-dev] [PATCH 23/23] st/mesa: enable shader subroutine

2015-04-24 Thread Marek Olšák
Yes, as long as it's core-only, dummy_true is fine. Marek On Fri, Apr 24, 2015 at 3:14 PM, Ilia Mirkin wrote: > The extension is currently marked as GLC, so that equates to dummy_true right? > > On Fri, Apr 24, 2015 at 9:00 AM, Brian Paul wrote: >> Yes, I second that. >> >> -Brian >> >> >> On 0

Re: [Mesa-dev] [PATCH 23/23] st/mesa: enable shader subroutine

2015-04-24 Thread Ilia Mirkin
The extension is currently marked as GLC, so that equates to dummy_true right? On Fri, Apr 24, 2015 at 9:00 AM, Brian Paul wrote: > Yes, I second that. > > -Brian > > > On 04/24/2015 04:29 AM, Marek Olšák wrote: >> >> I'd enable this if at least GLSL 1.30 was supported. I think drivers >> like r3

Re: [Mesa-dev] [PATCH 23/23] st/mesa: enable shader subroutine

2015-04-24 Thread Brian Paul
Yes, I second that. -Brian On 04/24/2015 04:29 AM, Marek Olšák wrote: I'd enable this if at least GLSL 1.30 was supported. I think drivers like r300, nv30, i915, and svga shouldn't get this. Marek On Fri, Apr 24, 2015 at 3:42 AM, Dave Airlie wrote: From: Dave Airlie I'm not sure if we sho

Re: [Mesa-dev] [PATCH 23/23] st/mesa: enable shader subroutine

2015-04-24 Thread Marek Olšák
I'd enable this if at least GLSL 1.30 was supported. I think drivers like r300, nv30, i915, and svga shouldn't get this. Marek On Fri, Apr 24, 2015 at 3:42 AM, Dave Airlie wrote: > From: Dave Airlie > > I'm not sure if we shouldn't enable this everywhere > and rip out the API checks, > > discus

[Mesa-dev] [PATCH 23/23] st/mesa: enable shader subroutine

2015-04-23 Thread Dave Airlie
From: Dave Airlie I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker