On 13 September 2017 at 22:15, Chad Versace wrote:
>> > +
>> > +static void UNUSED
>> > +static_asserts(void)
>> > +{
>> > + STATIC_ASSERT(HWVULKAN_DISPATCH_MAGIC == ICD_LOADER_MAGIC);
>> > +}
>
>> Seems like a left over? With that gone, there should be no need for vk_icd.h.
>
> I intended to le
On Wed 13 Sep 2017, Emil Velikov wrote:
> Hi Chad,
>
> On the topic of keep this in the driver vs separate module - I think
> it makes sense to keep it internal.
>
> Sure radv/others won't be able to reuse the code [that easily], at the
> same time it gives greater control and one could make more
On 13 September 2017 at 14:38, Emil Velikov wrote:
> b)
> - missing headers - system/window.h at least (from
> vk_android_native_buffer.h)
>
I stand corrected on this one. There's a hack/workaround that I've
missed - 2/23.
That said, I still think my earlier suggestion makes sense~ish.
Emil
__
Hi Chad,
On the topic of keep this in the driver vs separate module - I think
it makes sense to keep it internal.
Sure radv/others won't be able to reuse the code [that easily], at the
same time it gives greater control and one could make more optimal
decisions.
On 2 September 2017 at 09:17, Cha
On 09/02/2017 11:17 AM, Chad Versace wrote:
This implementation is correct (afaict), but takes two shortcuts
regarding the import/export of Android sync fds.
Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync
fd into a VkSemaphore or VkFence, the driver instead simply b
On September 2, 2017 1:20:09 AM Chad Versace wrote:
This implementation is correct (afaict), but takes two shortcuts
regarding the import/export of Android sync fds.
Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync
fd into a VkSemaphore or VkFence, the driver instead
On Sat, Sep 2, 2017 at 1:17 AM, Chad Versace
wrote:
> This implementation is correct (afaict), but takes two shortcuts
> regarding the import/export of Android sync fds.
>
> Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync
> fd into a VkSemaphore or VkFence, the driver in
This implementation is correct (afaict), but takes two shortcuts
regarding the import/export of Android sync fds.
Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync
fd into a VkSemaphore or VkFence, the driver instead simply blocks on
the sync fd, then puts the VkSemaphore
