Re: [Mesa-dev] [PATCH 22/59] compiler/nir: add lowering for 16-bit ldexp

2018-12-07 Thread Jason Ekstrand
On Wed, Dec 5, 2018 at 5:32 AM Pohjolainen, Topi wrote: > On Wed, Dec 05, 2018 at 12:26:06PM +0100, Iago Toral wrote: > > On Wed, 2018-12-05 at 13:20 +0200, Pohjolainen, Topi wrote: > > > On Wed, Dec 05, 2018 at 11:53:44AM +0100, Iago Toral wrote: > > > > On Wed, 2018-12-05 at 11:39 +0200, Pohjol

Re: [Mesa-dev] [PATCH 22/59] compiler/nir: add lowering for 16-bit ldexp

2018-12-05 Thread Pohjolainen, Topi
On Wed, Dec 05, 2018 at 12:26:06PM +0100, Iago Toral wrote: > On Wed, 2018-12-05 at 13:20 +0200, Pohjolainen, Topi wrote: > > On Wed, Dec 05, 2018 at 11:53:44AM +0100, Iago Toral wrote: > > > On Wed, 2018-12-05 at 11:39 +0200, Pohjolainen, Topi wrote: > > > > I remember people preferring to order t

Re: [Mesa-dev] [PATCH 22/59] compiler/nir: add lowering for 16-bit ldexp

2018-12-05 Thread Iago Toral
On Wed, 2018-12-05 at 13:20 +0200, Pohjolainen, Topi wrote: > On Wed, Dec 05, 2018 at 11:53:44AM +0100, Iago Toral wrote: > > On Wed, 2018-12-05 at 11:39 +0200, Pohjolainen, Topi wrote: > > > I remember people preferring to order things 16, 32, 64 before. > > > Should > > > we follow that here as w

Re: [Mesa-dev] [PATCH 22/59] compiler/nir: add lowering for 16-bit ldexp

2018-12-05 Thread Pohjolainen, Topi
On Wed, Dec 05, 2018 at 11:53:44AM +0100, Iago Toral wrote: > On Wed, 2018-12-05 at 11:39 +0200, Pohjolainen, Topi wrote: > > I remember people preferring to order things 16, 32, 64 before. > > Should > > we follow that here as well? > > Yes, it makes sense. I'll change that. > > > On Tue, Dec 04

Re: [Mesa-dev] [PATCH 22/59] compiler/nir: add lowering for 16-bit ldexp

2018-12-05 Thread Iago Toral
On Wed, 2018-12-05 at 11:39 +0200, Pohjolainen, Topi wrote: > I remember people preferring to order things 16, 32, 64 before. > Should > we follow that here as well? Yes, it makes sense. I'll change that. > On Tue, Dec 04, 2018 at 08:16:46AM +0100, Iago Toral Quiroga wrote: > > --- > > src/compi

Re: [Mesa-dev] [PATCH 22/59] compiler/nir: add lowering for 16-bit ldexp

2018-12-05 Thread Pohjolainen, Topi
I remember people preferring to order things 16, 32, 64 before. Should we follow that here as well? On Tue, Dec 04, 2018 at 08:16:46AM +0100, Iago Toral Quiroga wrote: > --- > src/compiler/nir/nir_opt_algebraic.py | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/compiler/nir/ni

[Mesa-dev] [PATCH 22/59] compiler/nir: add lowering for 16-bit ldexp

2018-12-03 Thread Iago Toral Quiroga
--- src/compiler/nir/nir_opt_algebraic.py | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index 6c3b77c9b6e..747f1751086 100644 --- a/src/compiler/nir/nir_opt_algebraic.py +++ b/src/compiler/nir/nir_opt_algebra