Re: [Mesa-dev] [PATCH 2/9] tgsi: fix tgsi transform's epilog callback

2014-09-22 Thread Brian Paul
Good point, but as it is this follows the convention that's been working all along so far. I can add a comment about looking for the final RET in the future. -Brian On 09/22/2014 11:50 AM, Roland Scheidegger wrote: Do you want to call it at (outermost) RET opcode (if any) instead? tgsi is ki

Re: [Mesa-dev] [PATCH 2/9] tgsi: fix tgsi transform's epilog callback

2014-09-22 Thread Roland Scheidegger
Do you want to call it at (outermost) RET opcode (if any) instead? tgsi is kinda undecided if there should be a ret opcode in main but sometimes there is... Roland Am 22.09.2014 17:44, schrieb Brian Paul: > We want to call the caller's epilog callback when we find the TGSI > END instruction, not

[Mesa-dev] [PATCH 2/9] tgsi: fix tgsi transform's epilog callback

2014-09-22 Thread Brian Paul
We want to call the caller's epilog callback when we find the TGSI END instruction, not after it. --- src/gallium/auxiliary/tgsi/tgsi_transform.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_transform.c b/src/gallium/au