Re: [Mesa-dev] [PATCH 2/7] intel: Remove the pbo zero-copy code.

2011-09-22 Thread Eric Anholt
On Thu, 22 Sep 2011 09:54:43 -0700, Ian Romanick wrote: > On 09/21/2011 10:15 AM, Eric Anholt wrote: > > There were notes about the possibility of slowdowns due to zcopy from > > a PBO due to thrashing around of the region. Slowdowns are even more > > likely now that textures are generally tiled,

Re: [Mesa-dev] [PATCH 2/7] intel: Remove the pbo zero-copy code.

2011-09-22 Thread Ian Romanick
On 09/21/2011 10:15 AM, Eric Anholt wrote: There were notes about the possibility of slowdowns due to zcopy from a PBO due to thrashing around of the region. Slowdowns are even more likely now that textures are generally tiled, which a zcopy wouldn't get. Additionally, there were no checks on t

Re: [Mesa-dev] [PATCH 2/7] intel: Remove the pbo zero-copy code.

2011-09-21 Thread Keith Whitwell
I'm suprised that fragile code lasted as long as it did... Looks good to me. Keith On Wed, 2011-09-21 at 10:15 -0700, Eric Anholt wrote: > There were notes about the possibility of slowdowns due to zcopy from > a PBO due to thrashing around of the region. Slowdowns are even more > likely now th

[Mesa-dev] [PATCH 2/7] intel: Remove the pbo zero-copy code.

2011-09-21 Thread Eric Anholt
There were notes about the possibility of slowdowns due to zcopy from a PBO due to thrashing around of the region. Slowdowns are even more likely now that textures are generally tiled, which a zcopy wouldn't get. Additionally, there were no checks on the buffer size to ensure that the hardware-re