[Mesa-dev] [PATCH 2/6] mesa: Fix GL error generation in glBlitFramebuffer()

2012-12-18 Thread Anuj Phogat
V2: If mask has GL_STENCIL_BUFFER_BIT set, the depth formats for readRenderBuffer and drawRenderBuffer must match unless one of the two buffers doesn't have depth, in which case it's not blitted, so the format check should be ignored. Same comment goes for stencil formats in depth renderbuffers if

Re: [Mesa-dev] [PATCH 2/6] mesa: Fix GL error generation in glBlitFramebuffer()

2012-12-18 Thread Anuj Phogat
On Tue, Dec 18, 2012 at 12:12 PM, Kenneth Graunke wrote: > On 12/18/2012 12:05 PM, Anuj Phogat wrote: >> >> On Tue, Dec 18, 2012 at 11:09 AM, Kenneth Graunke >> wrote: >>> >>> On 12/12/2012 03:25 PM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- src/mesa/main/fbob

Re: [Mesa-dev] [PATCH 2/6] mesa: Fix GL error generation in glBlitFramebuffer()

2012-12-18 Thread Kenneth Graunke
On 12/18/2012 12:05 PM, Anuj Phogat wrote: On Tue, Dec 18, 2012 at 11:09 AM, Kenneth Graunke wrote: On 12/12/2012 03:25 PM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- src/mesa/main/fbobject.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/me

Re: [Mesa-dev] [PATCH 2/6] mesa: Fix GL error generation in glBlitFramebuffer()

2012-12-18 Thread Anuj Phogat
On Tue, Dec 18, 2012 at 11:09 AM, Kenneth Graunke wrote: > On 12/12/2012 03:25 PM, Anuj Phogat wrote: >> >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/main/fbobject.c | 10 +- >> 1 files changed, 9 insertions(+), 1 deletions(-) >> >> diff --git a/src/mesa/main/fbobject.c b/src/mes

Re: [Mesa-dev] [PATCH 2/6] mesa: Fix GL error generation in glBlitFramebuffer()

2012-12-18 Thread Kenneth Graunke
On 12/12/2012 03:25 PM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- src/mesa/main/fbobject.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 4b7d4ab..9e32836 100644 --- a/src/mesa/main/fbobject.c

Re: [Mesa-dev] [PATCH 2/6] mesa: Fix GL error generation in glBlitFramebuffer()

2012-12-18 Thread Ian Romanick
On 12/12/2012 03:25 PM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- src/mesa/main/fbobject.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 4b7d4ab..9e32836 100644 --- a/src/mesa/main/fbobject.c

[Mesa-dev] [PATCH 2/6] mesa: Fix GL error generation in glBlitFramebuffer()

2012-12-12 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/main/fbobject.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 4b7d4ab..9e32836 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -2856,7 +285