Re: [Mesa-dev] [PATCH 2/6] i965/skl: Layout a 1D miptree horizontally

2015-03-24 Thread Anuj Phogat
On Fri, Feb 20, 2015 at 2:31 PM, Neil Roberts wrote: > On Gen9+ the 1D miptree is laid out with all of the mipmap levels in a > horizontal line. > --- > src/mesa/drivers/dri/i965/brw_tex_layout.c | 62 > +- > 1 file changed, 60 insertions(+), 2 deletions(-) > > diff -

Re: [Mesa-dev] [PATCH 2/6] i965/skl: Layout a 1D miptree horizontally

2015-02-25 Thread Neil Roberts
Ben Widawsky writes: > Okay, I'm guilty of a bikeshed here, but doesn't this look cleaner if you just > do two for loops? One for depth, and one for levels. > > something like... > const unsigned depth = mt->physical_depth0; > for (i = 0; i < depth; i++) { > width = mt->physical_width0; >

[Mesa-dev] [PATCH 2/6] i965/skl: Layout a 1D miptree horizontally

2015-02-20 Thread Neil Roberts
On Gen9+ the 1D miptree is laid out with all of the mipmap levels in a horizontal line. --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 62 +- 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c b/src/mesa/drivers/