Ben Widawsky writes:
> Gen9 adds the ability to write out a stencil value, so we need to expand the
> virtual payload by one. Abstracting this now makes that change easier to read.
>
> I was admittedly confused early on about some of the hardcoding. If people
> believe the resulting code is infer
On Tue, Oct 20, 2015 at 3:27 PM, Ben Widawsky wrote:
> On Tue, Oct 20, 2015 at 03:19:48PM -0700, Matt Turner wrote:
>> What I should have said in the previous email is that assigning
>> arbitrary numbers to enums in brw_defines.h is confusing because one
>> might be led to believe that these are h
On Tue, Oct 20, 2015 at 03:19:48PM -0700, Matt Turner wrote:
> On Tue, Oct 20, 2015 at 3:11 PM, Ben Widawsky wrote:
> > On Tue, Oct 20, 2015 at 02:57:24PM -0700, Matt Turner wrote:
> >> On Tue, Oct 20, 2015 at 2:54 PM, Ben Widawsky wrote:
> >> > On Tue, Oct 20, 2015 at 02:52:29PM -0700, Matt Turn
On Tue, Oct 20, 2015 at 3:11 PM, Ben Widawsky wrote:
> On Tue, Oct 20, 2015 at 02:57:24PM -0700, Matt Turner wrote:
>> On Tue, Oct 20, 2015 at 2:54 PM, Ben Widawsky wrote:
>> > On Tue, Oct 20, 2015 at 02:52:29PM -0700, Matt Turner wrote:
>> >> On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky
>> >>
On Tue, Oct 20, 2015 at 02:57:24PM -0700, Matt Turner wrote:
> On Tue, Oct 20, 2015 at 2:54 PM, Ben Widawsky wrote:
> > On Tue, Oct 20, 2015 at 02:52:29PM -0700, Matt Turner wrote:
> >> On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky
> >> wrote:
> >> > Gen9 adds the ability to write out a stencil v
On Tue, Oct 20, 2015 at 2:54 PM, Ben Widawsky wrote:
> On Tue, Oct 20, 2015 at 02:52:29PM -0700, Matt Turner wrote:
>> On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky
>> wrote:
>> > Gen9 adds the ability to write out a stencil value, so we need to expand
>> > the
>> > virtual payload by one. Abstr
On Tue, Oct 20, 2015 at 02:52:29PM -0700, Matt Turner wrote:
> On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky
> wrote:
> > Gen9 adds the ability to write out a stencil value, so we need to expand the
> > virtual payload by one. Abstracting this now makes that change easier to
> > read.
> >
> > I w
On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky
wrote:
> Gen9 adds the ability to write out a stencil value, so we need to expand the
> virtual payload by one. Abstracting this now makes that change easier to read.
>
> I was admittedly confused early on about some of the hardcoding. If people
> beli
Gen9 adds the ability to write out a stencil value, so we need to expand the
virtual payload by one. Abstracting this now makes that change easier to read.
I was admittedly confused early on about some of the hardcoding. If people
believe the resulting code is inferior, I am not super attached to
