Re: [Mesa-dev] [PATCH 2/6] glx: Use __glXSendError instead of open-coding it

2017-11-30 Thread Emil Velikov
On 14 November 2017 at 20:13, Adam Jackson wrote: > This also fixes a bug, the error path through MakeCurrent didn't > translate the error code by the extension's error base. > May I suggest splitting the MakeContextCurrent bugfix from the refactor? Reason being, that the refactor is not a no-op.

Re: [Mesa-dev] [PATCH 2/6] glx: Use __glXSendError instead of open-coding it

2017-11-14 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 11/14/2017 12:13 PM, Adam Jackson wrote: > This also fixes a bug, the error path through MakeCurrent didn't > translate the error code by the extension's error base. > > Signed-off-by: Adam Jackson > --- > src/glx/glxcmds.c| 10 +- > src/

[Mesa-dev] [PATCH 2/6] glx: Use __glXSendError instead of open-coding it

2017-11-14 Thread Adam Jackson
This also fixes a bug, the error path through MakeCurrent didn't translate the error code by the extension's error base. Signed-off-by: Adam Jackson --- src/glx/glxcmds.c| 10 +- src/glx/glxcurrent.c | 20 +++- 2 files changed, 4 insertions(+), 26 deletions(-) diff -