Re: [Mesa-dev] [PATCH 2/5] winsys/radeon: remove cs_queue_empty

2013-10-07 Thread Christian König
radeon_drm_cs_sync_flush doesn't seems to be save when it's called from multiple threads but thought that this might be intentional. Maybe we are running into that issue now that we are calling it more often. Changing that should be trivial, going to attach a possible fix to the bugreport in a

Re: [Mesa-dev] [PATCH 2/5] winsys/radeon: remove cs_queue_empty

2013-10-06 Thread Marek Olšák
This causes a deadlock and X freeze for some users. See the bug: https://bugs.freedesktop.org/show_bug.cgi?id=70123 Do you have any idea what's wrong there? Marek On Sat, Sep 21, 2013 at 4:41 PM, Christian König wrote: > From: Christian König > > Waiting for an empty queue is nonsense and can

[Mesa-dev] [PATCH 2/5] winsys/radeon: remove cs_queue_empty

2013-09-21 Thread Christian König
From: Christian König Waiting for an empty queue is nonsense and can lead to deadlocks if we have multiple waiters or another thread that continuously sends down new commands. Just post the cs to the queue and immediately wait for it to finish. This is a candidate for the stable branch. Signed