Re: [Mesa-dev] [PATCH 2/5] util: Add tests for the string buffer

2017-09-27 Thread Emil Velikov
On 11 September 2017 at 21:21, Thomas Helland wrote: > More tests could probably be added, but this should cover > concatenation, resizing, clearing, formatted printing, > and checking the length, so it should be quite complete. > > V2: Address review feedback from Timothy, plus fixes >- Use a

Re: [Mesa-dev] [PATCH 2/5] util: Add tests for the string buffer

2017-09-26 Thread Nicolai Hähnle
On 21.09.2017 21:13, Thomas Helland wrote: Fixed the missing newline at the end of this cpp file locally. This is the only patch left in the series without an RB. If there's no objections I plan on pushing this once I get an RB on this. Someone mind having a look at it? Sorry, I forgot to send

Re: [Mesa-dev] [PATCH 2/5] util: Add tests for the string buffer

2017-09-21 Thread Dieter Nützel
If you (all) think, an AK from me (Dieter) is enough, I'm running this from the beginning, then go ahead. Greetings, Dieter Am 21.09.2017 21:13, schrieb Thomas Helland: Fixed the missing newline at the end of this cpp file locally. This is the only patch left in the series without an RB. If th

Re: [Mesa-dev] [PATCH 2/5] util: Add tests for the string buffer

2017-09-21 Thread Thomas Helland
Fixed the missing newline at the end of this cpp file locally. This is the only patch left in the series without an RB. If there's no objections I plan on pushing this once I get an RB on this. Someone mind having a look at it? 2017-09-11 22:21 GMT+02:00 Thomas Helland : > More tests could probabl

[Mesa-dev] [PATCH 2/5] util: Add tests for the string buffer

2017-09-11 Thread Thomas Helland
More tests could probably be added, but this should cover concatenation, resizing, clearing, formatted printing, and checking the length, so it should be quite complete. V2: Address review feedback from Timothy, plus fixes - Use a large enough char array - Actually test the formatted appendi