Re: [Mesa-dev] [PATCH 2/5] nir: Make an easier helper for setting up SSA defs.

2015-01-21 Thread Jason Ekstrand
Yes, please. I've made that mistake enough myself. Reviewed-by: Jason Ekstrand On Wed, Jan 21, 2015 at 5:25 PM, Eric Anholt wrote: > Almost all instructions we nir_ssa_def_init() for are nir_dests, and you > have to keep from forgetting to set is_ssa when you do. Just provide the > simpler h

[Mesa-dev] [PATCH 2/5] nir: Make an easier helper for setting up SSA defs.

2015-01-21 Thread Eric Anholt
Almost all instructions we nir_ssa_def_init() for are nir_dests, and you have to keep from forgetting to set is_ssa when you do. Just provide the simpler helper, instead. --- src/glsl/nir/glsl_to_nir.cpp| 14 -- src/glsl/nir/nir.c | 8 src/gl