Re: [Mesa-dev] [PATCH 2/4] glsl: make ast_node destructor virtual

2017-05-31 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 05/31/2017 03:05 AM, Ian Romanick wrote: This patch is Reviewed-by: Ian Romanick On 05/30/2017 01:47 PM, Rob Herring wrote: Make ast_node destructor virtual to fix the following clang warning: src/compiler/glsl/ast.h:51:4: warning: destructor called on non-f

Re: [Mesa-dev] [PATCH 2/4] glsl: make ast_node destructor virtual

2017-05-30 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 05/30/2017 01:47 PM, Rob Herring wrote: > Make ast_node destructor virtual to fix the following clang warning: > > src/compiler/glsl/ast.h:51:4: warning: destructor called on non-final > 'ast_node' that has virtual functions but non-virtual destructor

[Mesa-dev] [PATCH 2/4] glsl: make ast_node destructor virtual

2017-05-30 Thread Rob Herring
Make ast_node destructor virtual to fix the following clang warning: src/compiler/glsl/ast.h:51:4: warning: destructor called on non-final 'ast_node' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] Signed-off-by: Rob Herring --- src/compiler/glsl/ast.h | 2 ++