Re: [Mesa-dev] [PATCH 2/4] DRI: Add DRIimage map and unmap functions

2016-05-03 Thread Eric Anholt
Rob Herring writes: > On Mon, Apr 25, 2016 at 7:42 AM, Daniel Stone wrote: >> Hi, >> >> On 22 April 2016 at 19:12, Eric Anholt wrote: >>> I think this needs a longer comment to explain what the interface does: >>> >>> "Returns a map of the specified region of a __DRIimage for the specified >>>

Re: [Mesa-dev] [PATCH 2/4] DRI: Add DRIimage map and unmap functions

2016-05-03 Thread Rob Herring
On Mon, Apr 25, 2016 at 7:42 AM, Daniel Stone wrote: > Hi, > > On 22 April 2016 at 19:12, Eric Anholt wrote: >> I think this needs a longer comment to explain what the interface does: >> >> "Returns a map of the specified region of a __DRIimage for the specified >> usage. >> >> flags must always

Re: [Mesa-dev] [PATCH 2/4] DRI: Add DRIimage map and unmap functions

2016-04-25 Thread Daniel Stone
Hi, On 22 April 2016 at 19:12, Eric Anholt wrote: > I think this needs a longer comment to explain what the interface does: > > "Returns a map of the specified region of a __DRIimage for the specified > usage. > > flags must always include __DRI_IMAGE_TRANSFER_READ and may include > __DRI_IMAGE_T

Re: [Mesa-dev] [PATCH 2/4] DRI: Add DRIimage map and unmap functions

2016-04-22 Thread Eric Anholt
Rob Herring writes: > Add mapImage and unmapImage functions to DRIimage extension for mapping > and unmapping DRIimages for CPU access. The caller provides the region of > the image to map and is returned a pointer to the beginning of the region > and the stride (which could be different from the

[Mesa-dev] [PATCH 2/4] DRI: Add DRIimage map and unmap functions

2016-04-22 Thread Rob Herring
Add mapImage and unmapImage functions to DRIimage extension for mapping and unmapping DRIimages for CPU access. The caller provides the region of the image to map and is returned a pointer to the beginning of the region and the stride (which could be different from the original). Signed-off-by: Ro