Re: [Mesa-dev] [PATCH 2/3] nir/gcm: Add value numbering support

2016-09-06 Thread Jason Ekstrand
On Sep 6, 2016 1:50 PM, "Eric Anholt" wrote: > > Jason Ekstrand writes: > > > --- > > This seems fine, but the commit message needs some expansion. Questions > I had: > > Does this help compared to an implementation with nir CSE already? Yes, value numbering is capable of detecting common value

Re: [Mesa-dev] [PATCH 2/3] nir/gcm: Add value numbering support

2016-09-06 Thread Eric Anholt
Jason Ekstrand writes: > --- This seems fine, but the commit message needs some expansion. Questions I had: Does this help compared to an implementation with nir CSE already? Does nir CSE still get us anything that this doesn't? signature.asc Description: PGP signature _

[Mesa-dev] [PATCH 2/3] nir/gcm: Add value numbering support

2016-09-06 Thread Jason Ekstrand
--- src/compiler/nir/nir.h | 2 +- src/compiler/nir/nir_opt_gcm.c | 29 - 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index c1cf940..ff7c422 100644 --- a/src/compiler/nir/nir.h +++ b/src/compil