Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-24 Thread Rob Clark
On Tue, May 24, 2016 at 3:41 PM, Rob Clark wrote: > On Mon, May 16, 2016 at 3:16 PM, Jason Ekstrand wrote: >> On Mon, May 16, 2016 at 9:09 AM, Rob Clark wrote: >>> >>> On Mon, May 16, 2016 at 10:45 AM, Jason Ekstrand >>> wrote: >>> > >>> > On May 16, 2016 7:29 AM, "Rob Clark" wrote: >>> >> >>>

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-24 Thread Rob Clark
On Mon, May 16, 2016 at 3:16 PM, Jason Ekstrand wrote: > On Mon, May 16, 2016 at 9:09 AM, Rob Clark wrote: >> >> On Mon, May 16, 2016 at 10:45 AM, Jason Ekstrand >> wrote: >> > >> > On May 16, 2016 7:29 AM, "Rob Clark" wrote: >> >> >> >> On Sat, May 14, 2016 at 4:03 PM, Jason Ekstrand >> >> wr

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-16 Thread Jason Ekstrand
On Mon, May 16, 2016 at 9:09 AM, Rob Clark wrote: > On Mon, May 16, 2016 at 10:45 AM, Jason Ekstrand > wrote: > > > > On May 16, 2016 7:29 AM, "Rob Clark" wrote: > >> > >> On Sat, May 14, 2016 at 4:03 PM, Jason Ekstrand > >> wrote: > >> > > >> > > >> > On Sat, May 14, 2016 at 12:20 PM, Rob Cla

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-16 Thread Rob Clark
On Mon, May 16, 2016 at 10:45 AM, Jason Ekstrand wrote: > > On May 16, 2016 7:29 AM, "Rob Clark" wrote: >> >> On Sat, May 14, 2016 at 4:03 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Sat, May 14, 2016 at 12:20 PM, Rob Clark wrote: >> >> >> >> On Thu, May 12, 2016 at 10:55 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-16 Thread Jason Ekstrand
On May 16, 2016 7:29 AM, "Rob Clark" wrote: > > On Sat, May 14, 2016 at 4:03 PM, Jason Ekstrand wrote: > > > > > > On Sat, May 14, 2016 at 12:20 PM, Rob Clark wrote: > >> > >> On Thu, May 12, 2016 at 10:55 PM, Jason Ekstrand > >> wrote: > >> > > >> > > >> > On Tue, May 10, 2016 at 11:57 AM, Rob

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-16 Thread Rob Clark
On Mon, May 16, 2016 at 10:45 AM, Jason Ekstrand wrote: > > On May 16, 2016 7:29 AM, "Rob Clark" wrote: >> >> On Sat, May 14, 2016 at 4:03 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Sat, May 14, 2016 at 12:20 PM, Rob Clark wrote: >> >> >> >> On Thu, May 12, 2016 at 10:55 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-16 Thread Ilia Mirkin
On Mon, May 16, 2016 at 10:45 AM, Jason Ekstrand wrote: > > On May 16, 2016 7:29 AM, "Rob Clark" wrote: >> >> On Sat, May 14, 2016 at 4:03 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Sat, May 14, 2016 at 12:20 PM, Rob Clark wrote: >> >> >> >> On Thu, May 12, 2016 at 10:55 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-16 Thread Rob Clark
On Sat, May 14, 2016 at 4:03 PM, Jason Ekstrand wrote: > > > On Sat, May 14, 2016 at 12:20 PM, Rob Clark wrote: >> >> On Thu, May 12, 2016 at 10:55 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Tue, May 10, 2016 at 11:57 AM, Rob Clark wrote: >> >> >> >> From: Rob Clark >> >> >> >> Some optimi

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-14 Thread Jason Ekstrand
On Sat, May 14, 2016 at 12:20 PM, Rob Clark wrote: > On Thu, May 12, 2016 at 10:55 PM, Jason Ekstrand > wrote: > > > > > > On Tue, May 10, 2016 at 11:57 AM, Rob Clark wrote: > >> > >> From: Rob Clark > >> > >> Some optimizations, like converting integer multiply/divide into left/ > >> right sh

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-14 Thread Rob Clark
On Thu, May 12, 2016 at 10:55 PM, Jason Ekstrand wrote: > > > On Tue, May 10, 2016 at 11:57 AM, Rob Clark wrote: >> >> From: Rob Clark >> >> Some optimizations, like converting integer multiply/divide into left/ >> right shifts, have additional constraints on the search expression. >> Like requi

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-12 Thread Jason Ekstrand
On Thu, May 12, 2016 at 8:12 PM, Matt Turner wrote: > On Tue, May 10, 2016 at 11:57 AM, Rob Clark wrote: > > From: Rob Clark > > > > Some optimizations, like converting integer multiply/divide into left/ > > right shifts, have additional constraints on the search expression. > > Like requiring

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-12 Thread Matt Turner
On Tue, May 10, 2016 at 11:57 AM, Rob Clark wrote: > From: Rob Clark > > Some optimizations, like converting integer multiply/divide into left/ > right shifts, have additional constraints on the search expression. > Like requiring that a variable is a constant power of two. Support > these cases

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-12 Thread Jason Ekstrand
On Tue, May 10, 2016 at 11:57 AM, Rob Clark wrote: > From: Rob Clark > > Some optimizations, like converting integer multiply/divide into left/ > right shifts, have additional constraints on the search expression. > Like requiring that a variable is a constant power of two. Support > these case

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-10 Thread Kenneth Graunke
On Tuesday, May 10, 2016 2:57:03 PM PDT Rob Clark wrote: > From: Rob Clark > > Some optimizations, like converting integer multiply/divide into left/ > right shifts, have additional constraints on the search expression. > Like requiring that a variable is a constant power of two. Support > these

[Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-10 Thread Rob Clark
From: Rob Clark Some optimizations, like converting integer multiply/divide into left/ right shifts, have additional constraints on the search expression. Like requiring that a variable is a constant power of two. Support these cases by allowing a fxn name to be appended to the search var expres

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-09 Thread Ilia Mirkin
On Mon, May 9, 2016 at 12:52 PM, Rob Clark wrote: > From: Rob Clark > > It was kinda sad that we couldn't optimize imul/idiv by power-of-two. > So I bashed my head against python for a while and this is what I came > up with. In the search expression, you can use "#a^2" to only match > constants

[Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

2016-05-09 Thread Rob Clark
From: Rob Clark It was kinda sad that we couldn't optimize imul/idiv by power-of-two. So I bashed my head against python for a while and this is what I came up with. In the search expression, you can use "#a^2" to only match constants which are a power of two. The rest is taken care of w/ norma