Re: [Mesa-dev] [PATCH 2/3] main: Checking for cube completeness in GetTextureImage.

2015-01-05 Thread Chad Versace
On 01/05/2015 10:34 AM, Laura Ekstrand wrote: > I added a clearer explanation based on our irc discussion: > > http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-textures&id=db418437915bba959c0b6c8babe40f675bbdf31c Thanks. LGTM. signature.asc Description: OpenPGP digital signature

Re: [Mesa-dev] [PATCH 2/3] main: Checking for cube completeness in GetTextureImage.

2015-01-05 Thread Laura Ekstrand
I added a clearer explanation based on our irc discussion: http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-textures&id=db418437915bba959c0b6c8babe40f675bbdf31c On Thu, Jan 1, 2015 at 11:15 AM, Chad Versace wrote: > On 12/31/2014 05:26 PM, Laura Ekstrand wrote: > > This is part of a poten

Re: [Mesa-dev] [PATCH 2/3] main: Checking for cube completeness in GetTextureImage.

2015-01-01 Thread Chad Versace
On 12/31/2014 05:26 PM, Laura Ekstrand wrote: > This is part of a potential solution to Khronos Bug 13223. Cube completeness > is a concept from glGenerateMipmap, but it seems reasonable to check for it in > GetTextureImage when the target is GL_TEXTURE_CUBE_MAP. > --- > src/mesa/main/texgetimage

[Mesa-dev] [PATCH 2/3] main: Checking for cube completeness in GetTextureImage.

2014-12-31 Thread Laura Ekstrand
This is part of a potential solution to Khronos Bug 13223. Cube completeness is a concept from glGenerateMipmap, but it seems reasonable to check for it in GetTextureImage when the target is GL_TEXTURE_CUBE_MAP. --- src/mesa/main/texgetimage.c | 41 + 1 fil