Re: [Mesa-dev] [PATCH 2/3] intel: Fix height in stencil buffer region allocation

2011-07-11 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/11/2011 12:08 PM, Eric Anholt wrote: > On Sat, 9 Jul 2011 09:01:07 -0700, Chad Versace wrote: >> If the height of the stencil buffer were odd, then we allocated a region >> whose height was too small --- `height / 2` rather than >> `height / 2

Re: [Mesa-dev] [PATCH 2/3] intel: Fix height in stencil buffer region allocation

2011-07-11 Thread Eric Anholt
On Sat, 9 Jul 2011 09:01:07 -0700, Chad Versace wrote: > If the height of the stencil buffer were odd, then we allocated a region > whose height was too small --- `height / 2` rather than > `height / 2 + height % 2`. Generally this is written "(height + 1) / 2" or "ALIGN(height, 2) / 2". So, di

[Mesa-dev] [PATCH 2/3] intel: Fix height in stencil buffer region allocation

2011-07-09 Thread Chad Versace
If the height of the stencil buffer were odd, then we allocated a region whose height was too small --- `height / 2` rather than `height / 2 + height % 2`. On gen5 with intel_screen.hw_must_use_separate_stencil enabled, Fixes-Piglit-test: fbo-stencil-* Note: This is a candidate for the 7.11 branc