Re: [Mesa-dev] [PATCH 2/3] i965/fs: Fix comparisions with uint negation.

2011-10-06 Thread Eric Anholt
On Tue, 04 Oct 2011 23:55:21 -0700, Kenneth Graunke wrote: > On 10/03/2011 03:41 PM, Eric Anholt wrote: > > The condmod instruction ends up generating garbage condition codes, > > because apparently the comparison happens on the accumulator value (33 > > bits for UD), not the truncated value that

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Fix comparisions with uint negation.

2011-10-05 Thread Paul Berry
On 4 October 2011 23:55, Kenneth Graunke wrote: > On 10/03/2011 03:41 PM, Eric Anholt wrote: > > The condmod instruction ends up generating garbage condition codes, > > because apparently the comparison happens on the accumulator value (33 > > bits for UD), not the truncated value that would be w

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Fix comparisions with uint negation.

2011-10-04 Thread Kenneth Graunke
On 10/03/2011 03:41 PM, Eric Anholt wrote: > The condmod instruction ends up generating garbage condition codes, > because apparently the comparison happens on the accumulator value (33 > bits for UD), not the truncated value that would be written. > > Fixes fs-op-neg-* I am uneasy about these tw

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Fix comparisions with uint negation.

2011-10-04 Thread Ian Romanick
On 10/04/2011 10:37 AM, Eric Anholt wrote: On Mon, 03 Oct 2011 16:34:28 -0700, Ian Romanick wrote: On 10/03/2011 03:41 PM, Eric Anholt wrote: diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 2000180..555d26d 100644 --- a/src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Fix comparisions with uint negation.

2011-10-04 Thread Eric Anholt
On Mon, 03 Oct 2011 16:34:28 -0700, Ian Romanick wrote: > On 10/03/2011 03:41 PM, Eric Anholt wrote: > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > > b/src/mesa/drivers/dri/i965/brw_fs.cpp > > index 2000180..555d26d 100644 > > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp > > +++ b/src/mes

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Fix comparisions with uint negation.

2011-10-03 Thread Ian Romanick
On 10/03/2011 03:41 PM, Eric Anholt wrote: The condmod instruction ends up generating garbage condition codes, because apparently the comparison happens on the accumulator value (33 bits for UD), not the truncated value that would be written. Fixes fs-op-neg-* --- src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 2/3] i965/fs: Fix comparisions with uint negation.

2011-10-03 Thread Eric Anholt
The condmod instruction ends up generating garbage condition codes, because apparently the comparison happens on the accumulator value (33 bits for UD), not the truncated value that would be written. Fixes fs-op-neg-* --- src/mesa/drivers/dri/i965/brw_fs.cpp | 13 + src/mesa