Re: [Mesa-dev] [PATCH 2/3] glsl: Tidy stream handling in merge_qualifier().

2016-08-11 Thread Kenneth Graunke
On Friday, August 12, 2016 9:44:42 AM PDT Timothy Arceri wrote: > On Thu, 2016-08-11 at 13:43 -0700, Kenneth Graunke wrote: > > The previous commit fixed xfb_buffer handling, which was largely copy > > and pasted from the stream handling. The difference is that stream > > was set in input_layout_m

Re: [Mesa-dev] [PATCH 2/3] glsl: Tidy stream handling in merge_qualifier().

2016-08-11 Thread Timothy Arceri
On Thu, 2016-08-11 at 13:43 -0700, Kenneth Graunke wrote: > The previous commit fixed xfb_buffer handling, which was largely copy > and pasted from the stream handling.  The difference is that stream > was set in input_layout_mask, so it worked. > > However, that's totally rubbish: stream is only

[Mesa-dev] [PATCH 2/3] glsl: Tidy stream handling in merge_qualifier().

2016-08-11 Thread Kenneth Graunke
The previous commit fixed xfb_buffer handling, which was largely copy and pasted from the stream handling. The difference is that stream was set in input_layout_mask, so it worked. However, that's totally rubbish: stream is only valid on geometry shader outputs. Presumably this was to hack aroun