Re: [Mesa-dev] [PATCH 2/2] vbo: implement primitive merging for glBegin/End sequences

2013-05-03 Thread Brian Paul
On 05/03/2013 03:52 PM, Eric Anholt wrote: Brian Paul writes: diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index b8dd90c..9ce3c6e 100644 --- a/src/mesa/vbo/vbo_save_api.c +++ b/src/mesa/vbo/vbo_save_api.c @@ -305,9 +305,9 @@ _save_reset_counters(struct gl_context *ctx)

Re: [Mesa-dev] [PATCH 2/2] vbo: implement primitive merging for glBegin/End sequences

2013-05-03 Thread Eric Anholt
Brian Paul writes: > diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c > index b8dd90c..9ce3c6e 100644 > --- a/src/mesa/vbo/vbo_save_api.c > +++ b/src/mesa/vbo/vbo_save_api.c > @@ -305,9 +305,9 @@ _save_reset_counters(struct gl_context *ctx) > * previous prim. > */ > stat

Re: [Mesa-dev] [PATCH 2/2] vbo: implement primitive merging for glBegin/End sequences

2013-05-03 Thread Jose Fonseca
Series looks alright AFAICT. Jose - Original Message - > A surprising number of apps and benchmarks have poor code like this: > > glBegin(GL_LINE_STRIP); > glVertex(v1); > glVertex(v2); > glEnd(); > // Possibly some no-op state changes here > glBegin(GL_LINE_STRIP); > glVertex(v3); > glVe

[Mesa-dev] [PATCH 2/2] vbo: implement primitive merging for glBegin/End sequences

2013-05-02 Thread Brian Paul
A surprising number of apps and benchmarks have poor code like this: glBegin(GL_LINE_STRIP); glVertex(v1); glVertex(v2); glEnd(); // Possibly some no-op state changes here glBegin(GL_LINE_STRIP); glVertex(v3); glVertex(v4); glEnd(); // repeat many, many times. The above sequence can be converted