Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Marek Olšák
On Mon, May 8, 2017 at 8:46 PM, Rob Clark wrote: > On Mon, May 8, 2017 at 1:52 PM, Marek Olšák wrote: >> On Mon, May 8, 2017 at 7:28 PM, Rob Clark wrote: >>> This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. >>> (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Marek Olšák
On Mon, May 8, 2017 at 7:58 PM, Ilia Mirkin wrote: > On Mon, May 8, 2017 at 1:52 PM, Marek Olšák wrote: >> On Mon, May 8, 2017 at 7:28 PM, Rob Clark wrote: >>> This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. >>> (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_ind

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Rob Clark
On Mon, May 8, 2017 at 1:52 PM, Marek Olšák wrote: > On Mon, May 8, 2017 at 7:28 PM, Rob Clark wrote: >> This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. >> (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..) >> Nouveau also uses min/max_index, so wouldn't be

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Ilia Mirkin
On Mon, May 8, 2017 at 1:52 PM, Marek Olšák wrote: > On Mon, May 8, 2017 at 7:28 PM, Rob Clark wrote: >> This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. >> (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..) >> Nouveau also uses min/max_index, so wouldn't be

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Marek Olšák
On Mon, May 8, 2017 at 7:28 PM, Rob Clark wrote: > This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. > (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..) > Nouveau also uses min/max_index, so wouldn't be surprised if this commit > causes problems there too.. >

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Rob Clark
This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..) Nouveau also uses min/max_index, so wouldn't be surprised if this commit causes problems there too.. Any particular need for this commit, or can I push a revert

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-04-28 Thread Nicolai Hähnle
Thanks for this. Series is Reviewed-by: Nicolai Hähnle On 26.04.2017 11:35, Marek Olšák wrote: From: Marek Olšák also remove the incorrect comment about primitive restart. --- src/mesa/state_tracker/st_draw.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-04-26 Thread Marek Olšák
From: Marek Olšák also remove the incorrect comment about primitive restart. --- src/mesa/state_tracker/st_draw.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c index d710284..e510d43 100644 --- a/s