Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-11 Thread Mao, David
nl] > Sent: Thursday, January 11, 2018 5:59 PM > To: Mao, David > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles. > > Now that I reread your email, no, that is not how we do it. > > For each bit i, we inte

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-11 Thread Bas Nieuwenhuizen
:59 PM > To: Mao, David > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles. > > Now that I reread your email, no, that is not how we do it. > > For each bit i, we interpret the i itself as a bitmask. So e.g. if we

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-11 Thread Mao, David
ubject: Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles. Now that I reread your email, no, that is not how we do it. For each bit i, we interpret the i itself as a bitmask. So e.g. if we have 3 rectangles in inclusive mode, the bits set would be any i, that has at least on

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-11 Thread Bas Nieuwenhuizen
Of > Bas Nieuwenhuizen > Sent: Wednesday, January 10, 2018 10:34 AM > To: mesa-dev@lists.freedesktop.org > Cc: Bas Nieuwenhuizen > Subject: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles. > > Tested with a modified deferred demo and no regressions in a 1.0.2 m

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-11 Thread Bas Nieuwenhuizen
f > Bas Nieuwenhuizen > Sent: Wednesday, January 10, 2018 10:34 AM > To: mesa-dev@lists.freedesktop.org > Cc: Bas Nieuwenhuizen > Subject: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles. > > Tested with a modified deferred demo and no regressions in

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-10 Thread Mao, David
, David -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Bas Nieuwenhuizen Sent: Wednesday, January 10, 2018 10:34 AM To: mesa-dev@lists.freedesktop.org Cc: Bas Nieuwenhuizen Subject: [Mesa-dev] [PATCH 2/2] radv: Implement

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-10 Thread Samuel Pitoiset
On 01/10/2018 11:45 AM, Bas Nieuwenhuizen wrote: On Wed, Jan 10, 2018 at 11:16 AM, Samuel Pitoiset wrote: On 01/10/2018 03:34 AM, Bas Nieuwenhuizen wrote: Tested with a modified deferred demo and no regressions in a 1.0.2 mustpass run. --- src/amd/vulkan/radv_cmd_buffer.c | 51 +++

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-10 Thread Bas Nieuwenhuizen
On Wed, Jan 10, 2018 at 11:16 AM, Samuel Pitoiset wrote: > > > On 01/10/2018 03:34 AM, Bas Nieuwenhuizen wrote: >> >> Tested with a modified deferred demo and no regressions in a 1.0.2 >> mustpass run. >> --- >> src/amd/vulkan/radv_cmd_buffer.c | 51 >> +++ >>

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-10 Thread Samuel Pitoiset
On 01/10/2018 03:34 AM, Bas Nieuwenhuizen wrote: Tested with a modified deferred demo and no regressions in a 1.0.2 mustpass run. --- src/amd/vulkan/radv_cmd_buffer.c | 51 +++ src/amd/vulkan/radv_device.c | 6 + src/amd/vulkan/radv_extensions.

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-09 Thread Dave Airlie
On 10 January 2018 at 12:34, Bas Nieuwenhuizen wrote: > Tested with a modified deferred demo and no regressions in a 1.0.2 > mustpass run. For the series: Reviewed-by: Dave Airlie > --- > src/amd/vulkan/radv_cmd_buffer.c | 51 > +++ > src/amd/vulkan/radv_

[Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

2018-01-09 Thread Bas Nieuwenhuizen
Tested with a modified deferred demo and no regressions in a 1.0.2 mustpass run. --- src/amd/vulkan/radv_cmd_buffer.c | 51 +++ src/amd/vulkan/radv_device.c | 6 + src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_pipeline.c| 35 ++