Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-21 Thread Bruno Jimenez
On Mon, 2018-05-21 at 09:34 -0500, Aaron Watry wrote: > On Mon, May 21, 2018 at 9:34 AM, Aaron Watry > wrote: > > On Mon, May 21, 2018 at 6:25 AM, Bruno Jimenez > m> wrote: > > > On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote: > > > > On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote: > >

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-21 Thread Aaron Watry
On Mon, May 21, 2018 at 9:34 AM, Aaron Watry wrote: > On Mon, May 21, 2018 at 6:25 AM, Bruno Jimenez wrote: >> On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote: >>> On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote: >>> > On Fri, May 18, 2018 at 1:15 PM, Jan Vesely >> > > wrote: >>> > > On

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-21 Thread Aaron Watry
On Mon, May 21, 2018 at 6:25 AM, Bruno Jimenez wrote: > On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote: >> On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote: >> > On Fri, May 18, 2018 at 1:15 PM, Jan Vesely > > > wrote: >> > > On Thu, 2018-05-17 at 19:20 -0500, Aaron Watry wrote: >> > > >

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-21 Thread Bruno Jimenez
On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote: > On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote: > > On Fri, May 18, 2018 at 1:15 PM, Jan Vesely > > wrote: > > > On Thu, 2018-05-17 at 19:20 -0500, Aaron Watry wrote: > > > > They're not used anywhere else, so keep them private > > > >

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-18 Thread Jan Vesely
On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote: > On Fri, May 18, 2018 at 1:15 PM, Jan Vesely wrote: > > On Thu, 2018-05-17 at 19:20 -0500, Aaron Watry wrote: > > > They're not used anywhere else, so keep them private > > > > > > Signed-off-by: Aaron Watry > > > > I'm not sure what the or

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-18 Thread Aaron Watry
On Fri, May 18, 2018 at 1:15 PM, Jan Vesely wrote: > On Thu, 2018-05-17 at 19:20 -0500, Aaron Watry wrote: >> They're not used anywhere else, so keep them private >> >> Signed-off-by: Aaron Watry > > I'm not sure what the original purpose of the removed functions was. If > you recall please add i

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-18 Thread Jan Vesely
On Thu, 2018-05-17 at 19:20 -0500, Aaron Watry wrote: > They're not used anywhere else, so keep them private > > Signed-off-by: Aaron Watry I'm not sure what the original purpose of the removed functions was. If you recall please add it to the commit message. Either way: Reviewed-by: Jan Vesely

[Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-17 Thread Aaron Watry
They're not used anywhere else, so keep them private Signed-off-by: Aaron Watry --- .../drivers/r600/compute_memory_pool.c| 35 +++ .../drivers/r600/compute_memory_pool.h| 24 - 2 files changed, 29 insertions(+), 30 deletions(-) diff --git a/src/galli