Re: [Mesa-dev] [PATCH 2/2] nir: fix shift for uint64_t

2017-12-12 Thread Nicolai Hähnle
I have a slight preference for Jason's suggestion, but either way, both patches: Reviewed-by: Nicolai Hähnle On 12.12.2017 04:47, Timothy Arceri wrote: --- src/compiler/nir/nir_lower_io_arrays_to_elements.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compil

Re: [Mesa-dev] [PATCH 2/2] nir: fix shift for uint64_t

2017-12-11 Thread Jason Ekstrand
How about just using 1ull? On Mon, Dec 11, 2017 at 7:47 PM, Timothy Arceri wrote: > --- > src/compiler/nir/nir_lower_io_arrays_to_elements.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/compiler/nir/nir_lower_io_arrays_to_elements.c > b/src/compiler/nir/nir_l

[Mesa-dev] [PATCH 2/2] nir: fix shift for uint64_t

2017-12-11 Thread Timothy Arceri
--- src/compiler/nir/nir_lower_io_arrays_to_elements.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_lower_io_arrays_to_elements.c b/src/compiler/nir/nir_lower_io_arrays_to_elements.c index dca5719f114..cdf9a76a881 100644 --- a/src/compiler/nir/nir_l