Re: [Mesa-dev] [PATCH 2/2] nir: Stop using designated initializers

2015-01-21 Thread Dave Airlie
On 22 January 2015 at 06:19, Jason Ekstrand wrote: > > > On Wed, Jan 21, 2015 at 12:19 PM, Connor Abbott wrote: >> >> Assuming this actually compiles with GCC 4.4... > > > I don't know for sure, but it certainly gets us closer > --Jason > Much closer, CC nir_search.lo ../../src/glsl/nir/nir

Re: [Mesa-dev] [PATCH 2/2] nir: Stop using designated initializers

2015-01-21 Thread Jason Ekstrand
On Wed, Jan 21, 2015 at 12:19 PM, Connor Abbott wrote: > Assuming this actually compiles with GCC 4.4... > I don't know for sure, but it certainly gets us closer --Jason > > Reviewed-by: Connor Abbott > > On Wed, Jan 21, 2015 at 2:14 PM, Jason Ekstrand > wrote: > > Designated initializers wi

Re: [Mesa-dev] [PATCH 2/2] nir: Stop using designated initializers

2015-01-21 Thread Connor Abbott
Assuming this actually compiles with GCC 4.4... Reviewed-by: Connor Abbott On Wed, Jan 21, 2015 at 2:14 PM, Jason Ekstrand wrote: > Designated initializers with anonymous unions don't work in MSVC or > GCC < 4.6. With a couple of constructor methods, we don't need them any > more and the code

[Mesa-dev] [PATCH 2/2] nir: Stop using designated initializers

2015-01-21 Thread Jason Ekstrand
Designated initializers with anonymous unions don't work in MSVC or GCC < 4.6. With a couple of constructor methods, we don't need them any more and the code is actually cleaner. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88467 --- src/glsl/nir/nir_from_ssa.c | 30 +++