Re: [Mesa-dev] [PATCH 2/2] nir: Remove unused variable unroll_loc

2019-03-11 Thread Alyssa Rosenzweig
> The first patch was fine. Just not the second. First patch is a duplicate of the linked patch. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] nir: Remove unused variable unroll_loc

2019-03-11 Thread Jason Ekstrand
On March 11, 2019 22:17:38 Alyssa Rosenzweig wrote: [1] https://patchwork.freedesktop.org/patch/291616/ Ah-ha, somebody who knows what they're doing. That's good; ignore this series then :) The first patch was fine. Just not the second. --- So is this a "no" for the deleting ~/mesa/sr

Re: [Mesa-dev] [PATCH 2/2] nir: Remove unused variable unroll_loc

2019-03-11 Thread Alyssa Rosenzweig
> [1] https://patchwork.freedesktop.org/patch/291616/ Ah-ha, somebody who knows what they're doing. That's good; ignore this series then :) --- So is this a "no" for the deleting ~/mesa/src idea? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/2] nir: Remove unused variable unroll_loc

2019-03-11 Thread Timothy Arceri
On 12/3/19 2:09 pm, Alyssa Rosenzweig wrote: A better fix might be to delete the Mesa src tree, that should fix up any warnings :P Huh, so it does! No regressions on dEQP, possibly since all the tests were failing to begin with on Panfrost. I can only assume this was sent out by mistake? T

Re: [Mesa-dev] [PATCH 2/2] nir: Remove unused variable unroll_loc

2019-03-11 Thread Alyssa Rosenzweig
> A better fix might be to delete the Mesa src tree, that should fix up any > warnings :P Huh, so it does! No regressions on dEQP, possibly since all the tests were failing to begin with on Panfrost. > I can only assume this was sent out by mistake? This was sent out by "I don't know what I'm d

Re: [Mesa-dev] [PATCH 2/2] nir: Remove unused variable unroll_loc

2019-03-11 Thread Timothy Arceri
On 12/3/19 1:30 pm, Alyssa Rosenzweig wrote: Fixes a gcc warning. Signed-off-by: Alyssa Rosenzweig --- src/compiler/nir/nir_opt_loop_unroll.c | 4 1 file changed, 4 deletions(-) diff --git a/src/compiler/nir/nir_opt_loop_unroll.c b/src/compiler/nir/nir_opt_loop_unroll.c index 9ab0a9

[Mesa-dev] [PATCH 2/2] nir: Remove unused variable unroll_loc

2019-03-11 Thread Alyssa Rosenzweig
Fixes a gcc warning. Signed-off-by: Alyssa Rosenzweig --- src/compiler/nir/nir_opt_loop_unroll.c | 4 1 file changed, 4 deletions(-) diff --git a/src/compiler/nir/nir_opt_loop_unroll.c b/src/compiler/nir/nir_opt_loop_unroll.c index 9ab0a924c82..41f7a834164 100644 --- a/src/compiler/nir/ni